-
Notifications
You must be signed in to change notification settings - Fork 5
chore: fix code coverage report #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
grablack
wants to merge
18
commits into
develop
Choose a base branch
from
chore/fix-coverage-report
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new module `manifest-merger-test` to verify that the PayPal Messages library does not cause `android:usesCleartextTraffic` manifest merger conflicts. - Updated `.github/workflows/test.yml` to include a new CI job `test_manifest_merger` for automated testing. - Added necessary files including `build.gradle`, `AndroidManifest.xml`, and a test script to facilitate the testing process. - Updated `settings.gradle` to include the new test module.
…patibility - Updated the Kover plugin version in `library/build.gradle` from 0.9.1 to 0.7.6. - Commented out path normalization configuration in Kover tasks for compatibility with the downgraded version. - Added Kover plugin to `settings.gradle` for proper management.
Code Coverage
|
- Added comprehensive unit tests for `LogoAsset` to verify asset creation, equality, and type hierarchy. - Implemented tests for `PayPalMessageConfig` and `ModalConfig` to ensure proper handling of null values, default parameters, and various offer types. - Included tests for callback invocations in `PayPalComposableMessageTest` and `PayPalComposableModalTest` to validate event handling. - Enhanced coverage for edge cases, including different environments and amounts in modal configurations.
…and assertions - Updated `PayPalComposableMessageTest` to test the DEVELOP environment with host and localhost configurations. - Enhanced `PayPalComposableModalTest` by adding `modalCloseButton` to various `ModalConfig` instances and updating assertions for edge cases. - Improved error handling tests by changing `InvalidClientId` to `InvalidClientIdException` for better clarity. - Added assertions to verify default values and configurations in modal tests.
… temporarily disable Kover plugin - Enhanced `PayPalComposableModalTest` by adding assertions for `closeButton` properties to ensure correct default values. - Commented out Kover plugin in `build.gradle` due to dependency resolution issues, with a note for future re-enablement.
…eporting - Re-enabled the Kover plugin in `build.gradle` after resolving previous dependency issues. - Updated comments to clarify the configuration for Kover tasks and coverage report path normalization. - Added notes for temporarily disabling Kover tasks to address potential SSL/dependency issues.
…PayPalMessageData, PayPalMessageStyle, and ModalConfig - Introduced new tests for `Channel` to verify string representation and value retrieval. - Enhanced `ProductGroupTest` with additional assertions for value retrieval and size. - Added tests in `PayPalMessageConfigTest` to check equality, data mutability, and default style values. - Expanded `PayPalMessageDataTest` to include tests for default environment, nullable fields, equality, and field mutability. - Implemented tests in `PayPalMessageStyleTest` for default values, equality, and various style combinations. - Added tests in `ModalConfigTest` to verify default values and field mutability.
…ub Actions workflow - Added a step to check for the existence of Kover report files before normalization. - Implemented error handling to ensure the coverage report file is present. - Updated path normalization to accommodate GitHub Actions runner paths and handle additional absolute paths. - Improved logging for successful path normalization completion.
- Add explicit :library: module prefix to koverXmlReportDebug task - Add new step to extract and display coverage percentage from XML report - Parse coverage counters to help diagnose low coverage issues - Better visibility into coverage calculation process 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Code Coverage
|
…overage reporting - Introduced a new Gradle task `testDebugUnitTestIsolated` to run isolated memory-intensive tests, improving resource management and preventing OOM errors. - Configured the task to include specific tests and increased memory limits for better performance. - Updated the `koverXmlReportDebug` task to depend on both standard and isolated test tasks, ensuring comprehensive coverage data collection.
- Added the Kover plugin to the root `build.gradle` file without applying it. - Removed the isolated test task configuration from the `library/build.gradle` file, as it is now handled by the Kover plugin. - Updated comments to clarify the usage of Kover for coverage reporting.
Code Coverage
|
- Add excludeProjects configuration to explicitly exclude :demo module - This ensures coverage reports only include library module sources - Fixes Total Project Coverage showing 21.99% due to demo module inclusion
The excludeProjects property is not supported in Kover 0.7.6. The demo module exclusion is now handled in the root build.gradle via the subprojects block with isDisabled = true.
Code Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Testing instructions